Code review comment for lp://qastaging/~thisfred/desktopcouch/list-to-mergeable-list-mapping

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Thanks guys, all excellent points, will fix.

Nicola: pylint is (arguably) right about not complaining about unused constants: they are often imported by other modules. I will throw it out. I thought I was going to need both but I didn't. I did TDD this though :).

Also after further thought, I think we may want *another* slightly less simple mapping maybe, that does care about the values, so that it does not unintentionally stomp on changes from the backend.

Also because then we can correlate a list of simple values with a list of dictionaries more easily, which you'll now need to do by hand, but let's go with this for now, but use with care, i.e. try to get the values out of the record first, where applicable, and then do a sort of merge yourself, by looking at the values.

« Back to merge proposal