Merge lp://qastaging/~thisfred/desktopcouch/remove-recordtype-from-dict into lp://qastaging/desktopcouch
Proposed by
Eric Casteleijn
Status: | Merged | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Vincenzo Di Somma | ||||||||||||||||
Approved revision: | 218 | ||||||||||||||||
Merged at revision: | 207 | ||||||||||||||||
Proposed branch: | lp://qastaging/~thisfred/desktopcouch/remove-recordtype-from-dict | ||||||||||||||||
Merge into: | lp://qastaging/desktopcouch | ||||||||||||||||
Diff against target: |
444 lines (+116/-69) 6 files modified
desktopcouch/contacts/tests/test_record.py (+2/-3) desktopcouch/records/doc/an_example_application.txt (+1/-1) desktopcouch/records/record.py (+93/-58) desktopcouch/records/tests/test_record.py (+17/-5) desktopcouch/records/tests/test_server.py (+2/-1) utilities/lint.sh (+1/-1) |
||||||||||||||||
To merge this branch: | bzr merge lp://qastaging/~thisfred/desktopcouch/remove-recordtype-from-dict | ||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vincenzo Di Somma (community) | Approve | ||
Nicola Larosa (community) | Approve | ||
Review via email: mp+40916@code.qastaging.launchpad.net |
Commit message
Fixes #674487 where the record_type ended up in the dictionary of the record, where almost all client code had to filter it out again.
Fixes #669133 because the record_type version was never saved to CouchDB.
Fixes #575772 where the couchdb attachments API was defined on the wrong class.
Fixes #675787 where MergeableList.pop() could not be called without an index.
Description of the change
Fixed too much on this branch because I got a little frustrated with the number of bugs I ran into. If it's impossible to review, please tell me and I'll try and split all the fixes out into their own branches...
To post a comment you must log in.
Fixes #674487 where the record_type ended up in the dictionary of the record, where almost all client code had to filter it out again.
Fixes #669133 because the record_type version was never saved to CouchDB.
Fixes #575772 where the couchdb attachments API was defined on the wrong class.
Fixes #675787 where MergeableList.pop() could not be called without an index.