Code review comment for lp://qastaging/~thisfred/desktopcouch/split-attempt-2

200 - logging.exception("failed to back-up %s" % (srcname,))
201 + logging.exception("failed to back-up %s", (srcname,))

Shouldn't be a tuple now.

236 - super(Exception, self).__init__()
237 + super(NoOAuthTokenException, self).__init__()

Good catch. I wonder where that came from.

1895 + # XXX: is this here to swallow exceptions or ny mistake?

It's there to swallow exceptions. It's okay if couchdb isn't running.

2013 - logging.warn("There is no keyring to store our admin credentials.")
2014 + pass
2015 + ## logging.warn(
2016 + ## "There is no keyring to store our admin credentials.")
2017 except gnomekeyring.CancelledError:
2018 - logging.warn("There is no keyring to store our admin credentials.")
2019 + pass
2020 + ## logging.warn(
2021 + ## "There is no keyring to store our admin credentials.")

I don't understand this change.

2323 - self._mainloop.stop
2324 + # XXX: call this?
2325 + self._mainloop.stop # pylint: disable=W0104

Hrm, good question. Mocker is interesting this way. I'll look into this.