Merge lp://qastaging/~thisfred/ubuntuone-control-panel/gui-service into lp://qastaging/ubuntuone-control-panel

Proposed by Eric Casteleijn
Status: Merged
Approved by: Eric Casteleijn
Approved revision: 124
Merged at revision: 118
Proposed branch: lp://qastaging/~thisfred/ubuntuone-control-panel/gui-service
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 461 lines (+255/-33)
6 files modified
bin/ubuntuone-control-panel-gtk (+5/-17)
ubuntuone/controlpanel/gtk/__init__.py (+4/-2)
ubuntuone/controlpanel/gtk/gui.py (+93/-11)
ubuntuone/controlpanel/gtk/tests/__init__.py (+12/-0)
ubuntuone/controlpanel/gtk/tests/test_gui_basic.py (+40/-3)
ubuntuone/controlpanel/integrationtests/test_gui_service.py (+101/-0)
To merge this branch: bzr merge lp://qastaging/~thisfred/ubuntuone-control-panel/gui-service
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Natalia Bidart (community) Approve
Review via email: mp+55607@code.qastaging.launchpad.net

Commit message

This adds a method to the dbus service that allows switching between panels, and/or drawing attention to the control panel.

Description of the change

This adds a method to the dbus service that allows switching between panels, and/or drawing attention to the control panel.

To post a comment you must log in.
Revision history for this message
Eric Casteleijn (thisfred) wrote :

How to test:

in one terminal:

DEBUG=True PYTHONPATH=. ./bin/ubuntuone-control-panel-gtk --switch-to=devices

This opens the control panel with the devices tab open.

Then in another terminal:

DEBUG=True PYTHONPATH=. ./bin/ubuntuone-control-panel-gtk --switch-to=volumes

The second terminal should return (semi-)immediately, and the control panel should switch to the volumes panel.

Now start d-feet and look up the switch_to_alert method in com.ubuntuone.controlpanel.gui, and verify that it allows you to switch panels.

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

It works perfectly!

review: Approve
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches