platform-api

Merge lp://qastaging/~thomas-voss/platform-api/fix-1448180 into lp://qastaging/platform-api

  1. fix-1448180
  2. Merge into trunk
Proposed by Thomas Voß
Status: Needs review
Proposed branch: lp://qastaging/~thomas-voss/platform-api/fix-1448180
Merge into: lp://qastaging/platform-api
Prerequisite: lp://qastaging/~thomas-voss/platform-api/add-missing-functions-to-gps-itf
Diff against target: 1033 lines (+690/-40)
25 files modified
CMakeLists.txt (+1/-1)
TODO.txt (+1/-0)
android/hybris/Android.mk (+4/-0)
android/hybris/ubuntu_application_gps_for_hybris.cpp (+60/-3)
debian/changelog (+6/-0)
include/ubuntu/application/location/CMakeLists.txt (+2/-0)
include/ubuntu/application/location/service.h (+23/-0)
include/ubuntu/application/location/space_vehicle.h (+148/-0)
include/ubuntu/application/location/space_vehicle_update.h (+81/-0)
include/ubuntu/hardware/gps.h (+28/-28)
src/ubuntu/application/base_module.h (+1/-1)
src/ubuntu/application/common/application/location/CMakeLists.txt (+2/-0)
src/ubuntu/application/common/application/location/instance.h (+30/-1)
src/ubuntu/application/common/application/location/service.cpp (+8/-0)
src/ubuntu/application/common/application/location/space_vehicle.cpp (+70/-0)
src/ubuntu/application/common/application/location/space_vehicle_p.h (+40/-0)
src/ubuntu/application/common/application/location/space_vehicle_update.cpp (+44/-0)
src/ubuntu/application/common/application/location/space_vehicle_update_p.h (+41/-0)
src/ubuntu/application/desktop/module_version.h (+1/-1)
src/ubuntu/application/testbackend/module_version.h (+1/-1)
src/ubuntu/application/testbackend/test_stubs.cpp (+70/-0)
src/ubuntu/application/touch/module_version.h (+1/-1)
src/ubuntu/application/ubuntu_application_api.cpp (+15/-1)
src/ubuntu/hardware/tests/test_gps_api.cpp (+6/-2)
src/ubuntu/hardware/ubuntu_platform_hardware_api.cpp (+6/-0)
To merge this branch: bzr merge lp://qastaging/~thomas-voss/platform-api/fix-1448180
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Alberto Mardegan (community) Needs Fixing
Gerry Boland Pending
Review via email: mp+289664@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-12-03.

Commit message

Add reporting of updates to visible space vehicles.

Description of the change

Add reporting of updates to visible space vehicles.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:313
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~thomas-voss/platform-api/fix-1448180/+merge/274879/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/platform-api-ci/444/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/57/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/57/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/57/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/444/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:314
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~thomas-voss/platform-api/fix-1448180/+merge/274879/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/platform-api-ci/445/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/58/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/445/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:316
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~thomas-voss/platform-api/fix-1448180/+merge/274879/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/platform-api-ci/446/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/59
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/59
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/59/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/59

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/446/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote : Posted in a previous version of this proposal

A few minor nitpicks in the inline comments :-)

review: Approve
Revision history for this message
Gerry Boland (gerboland) wrote : Posted in a previous version of this proposal

+ ua_location_service_set_space_vehicle_update_handler(
How does one unset this? Using null? If so, please document that.

+ ua_location_sapce_vehicle_has_almanac_data(
+ ua_location_sapce_vehicle_has_ephimeris_data(
+ ua_location_sapce_vehicle_is_used_in_fix(
typo

Rest looks ok to me

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:319
http://jenkins.qa.ubuntu.com/job/platform-api-ci/449/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/62
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/62
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/62/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/62

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/449/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:320
http://jenkins.qa.ubuntu.com/job/platform-api-ci/450/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/63
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/63
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/63/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/63

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/450/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:321
http://jenkins.qa.ubuntu.com/job/platform-api-ci/451/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/64/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/64/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/64/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/451/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:322
http://jenkins.qa.ubuntu.com/job/platform-api-ci/452/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/65
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/65
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/65/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/65

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/452/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:323
http://jenkins.qa.ubuntu.com/job/platform-api-ci/453/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/66
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/66
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/66/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/66

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/453/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:324
http://jenkins.qa.ubuntu.com/job/platform-api-ci/454/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/67
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/67/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/67

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/454/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote : Posted in a previous version of this proposal

Code looks good & qtubuntu test app working nicely, approved

review: Approve
Revision history for this message
Alberto Mardegan (mardy) wrote :

Very minor comments inline. I'm marking this as need-fixing, but it's also fine if you leave it as is. Just let me know.

review: Needs Fixing
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:330
http://jenkins.qa.ubuntu.com/job/platform-api-ci/474/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/87
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/87
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/87/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/87

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/474/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

330. By Thomas Voß

Merge lp:~thomas-voss/platform-api/add-missing-functions-to-gps-itf.

329. By Thomas Voß

[ CI Train Bot ]
* debian/libubuntu-platform-hardware-api3.symbols: update to released
  version.
[ Simon Fels ]
* Workaround API break in Android GPS hardware abstraction API on MTK
  platforms. Each device which need this workaround has to add
[ Thomas Voß ]
* Expose performance boosting capabilities of the underlying
  HW/drivers.

328. By Thomas Voß

Adjust method signature.

327. By Thomas Voß

#ifdef access to mask pointers.

326. By Thomas Voß

Merge the other branch again :)

325. By Thomas Voß

[ Nick Dedekind ]
* Added api for destroying haptics sensor instance (LP:#1351109)
[ CI Train Bot ]
* debian/libubuntu-application-api3.symbols: update to released
  version.
* No-change rebuild.

324. By Thomas Voß

Revert location-service build-dep to enable dual landings.

323. By Thomas Voß

Actually implement subscription to space vehicle updates.

322. By Thomas Voß

Bump module versions.

321. By Thomas Voß

Add functions for subscribing to satellite visibility updates.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches