OpenLP

Merge lp://qastaging/~tomasgroth/openlp/fix-theme-thumb into lp://qastaging/openlp

  1. fix-theme-thumb
  2. Merge into trunk
Proposed by Tomas Groth
Status: Merged
Merged at revision: 2877
Proposed branch: lp://qastaging/~tomasgroth/openlp/fix-theme-thumb
Merge into: lp://qastaging/openlp
Diff against target: 541 lines (+148/-99)
9 files modified
openlp/core/display/render.py (+70/-27)
openlp/core/ui/media/vlcplayer.py (+14/-13)
openlp/core/ui/themeform.py (+20/-15)
openlp/core/ui/thememanager.py (+12/-14)
openlp/core/ui/themewizard.py (+9/-10)
openlp/plugins/media/lib/mediaitem.py (+10/-9)
openlp/plugins/songs/lib/songstab.py (+1/-1)
tests/functional/openlp_core/ui/test_thememanager.py (+9/-9)
tests/openlp_core/ui/test_themeform.py (+3/-1)
To merge this branch: bzr merge lp://qastaging/~tomasgroth/openlp/fix-theme-thumb
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Raoul Snyman Pending
Review via email: mp+368596@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-06-09.

Commit message

Add a webengine view for previewing themes.
Made VLC loading more robust.
A few minor fixes.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/176/ for more details

Revision history for this message
Tim Bentley (trb143) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

I like it, but you'll just need to fix the tests.

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/177/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/116/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.