OpenLP

Merge lp://qastaging/~tomasgroth/openlp/presentation-beyond-last into lp://qastaging/openlp

  1. presentation-beyond-last
  2. Merge into trunk
Proposed by Tomas Groth
Status: Merged
Merged at revision: 2875
Proposed branch: lp://qastaging/~tomasgroth/openlp/presentation-beyond-last
Merge into: lp://qastaging/openlp
Diff against target: 678 lines (+284/-58)
7 files modified
openlp/core/common/registry.py (+1/-1)
openlp/core/ui/servicemanager.py (+6/-0)
openlp/core/ui/slidecontroller.py (+22/-6)
openlp/plugins/presentations/lib/impresscontroller.py (+205/-22)
openlp/plugins/presentations/lib/messagelistener.py (+20/-20)
openlp/plugins/presentations/lib/powerpointcontroller.py (+25/-6)
openlp/plugins/presentations/lib/presentationcontroller.py (+5/-3)
To merge this branch: bzr merge lp://qastaging/~tomasgroth/openlp/presentation-beyond-last
Reviewer Review Type Date Requested Status
Phill Approve
Raoul Snyman Approve
Tim Bentley Pending
Review via email: mp+368353@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-05-29.

Commit message

Make it possible to go to next or previous service item when stepping through a presentation.
Disables impress and powerpoint presentation console.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/158/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/103/ for more details

Revision history for this message
Phill (phill-ridout) wrote : Posted in a previous version of this proposal

Whats happrning with the commented out code?

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/107/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

macOS tests failed, please see https://ci.openlp.io/job/MP-04-macOS-Tests/88/ for more details

Revision history for this message
Tim Bentley (trb143) wrote : Posted in a previous version of this proposal

Looks Ok.

review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

macOS tests passed!

Revision history for this message
Phill (phill-ridout) wrote : Posted in a previous version of this proposal

See line 189 for my main comment.

Others are just me being nit-picky!

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

macOS tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Looks OK to me.

review: Approve
Revision history for this message
Phill (phill-ridout) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.