Code review comment for lp://qastaging/~tpatil/nova/bug708822

Revision history for this message
Tushar Patil (tpatil) wrote :

Please check the following example

#test case: api server time is lacking by 5 seconds
    print "api server time is lacking by 5 seconds"
    now = datetime.datetime.utcnow() - datetime.timedelta(seconds=5);

    delta = now - datetime.datetime.utcnow();
    print delta

    #Modified code
    alive = delta < datetime.timedelta(seconds=60)
    #-5 < 60
    print alive

    #Current code"
    print delta.seconds
    alive = delta.seconds < 60
    #86395 < 60
    print alive

    print "api server time is ahead by 5 seconds"
    #test case: api server time is ahead by 5 seconds
    #API server time
    now = datetime.datetime.utcnow() + datetime.timedelta(seconds=5);
    delta = now - datetime.datetime.utcnow();
    print delta

    #Modified code
    alive = delta < datetime.timedelta(seconds=60)
    #5 < 60
    print alive

    print delta.seconds
    #5 < 60
    alive = delta.seconds < 60
    print alive

Output of the program
api server time is lacking by 5 seconds
-1 day, 23:59:55
True
86395
False
api server time is ahead by 5 seconds
0:00:05
True
5
True

« Back to merge proposal