Code review comment for lp://qastaging/~tpeeters/ubuntu-ui-toolkit/ActionBar-colors

Revision history for this message
Cris Dywan (kalikiana) wrote :

> - backgroundColor (background color of the full ActionBar)
> - pressedBackgroundColor (background color of the button when pressed)
That seems shaky. Two times a background color value, but applied to either the bar as a whole or individual buttons. You can't know from the name - ActionBarStyle even uses the backgroundColor for both the buttons and the whole bar, is this intentional? {pressedB,b}uttonBackgroundColor" would be clearer.

review: Needs Information

« Back to merge proposal