Code review comment for lp://qastaging/~tpeeters/ubuntu-ui-toolkit/crossFadeImage_SourceSize_fix

Revision history for this message
Michael Zanetti (mzanetti) wrote :

59 + } else if (internals.loadingImage && (sourceSize != Qt.size(internals.loadingImage.sourceSize.width, internals.loadingImage.sourceSize.height))) {

Hmm... Can it be that internals.loadingImage is null at some point? In that case setting the sourceSize would get lost if setting during that period. If it can't happen we can probably drop this check either. In any case I think the "internals.loadingImage &&" should not be here as the sourceSize gets bound to currentImage and nextImage directly anyways.

No tests?

review: Needs Information

« Back to merge proposal