Merge lp://qastaging/~ttx/nova/lp847768 into lp://qastaging/~hudson-openstack/nova/trunk

Proposed by Thierry Carrez
Status: Merged
Approved by: Dan Prince
Approved revision: 1542
Merged at revision: 1554
Proposed branch: lp://qastaging/~ttx/nova/lp847768
Merge into: lp://qastaging/~hudson-openstack/nova/trunk
Diff against target: 36 lines (+4/-4)
2 files modified
nova/tests/test_libvirt.py (+2/-2)
nova/virt/disk.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~ttx/nova/lp847768
Reviewer Review Type Date Requested Status
Dan Prince (community) Approve
Brian Waldon (community) Approve
Review via email: mp+74987@code.qastaging.launchpad.net

Commit message

Fixes rogue usage of sudo that crept in

Description of the change

Fixes rogue usage of sudo that crept in since all sudo calls were abstracted using run_as_root=True (and the root_helper flag).

The one in tests was actually fixed to match what Vish pushed in rev1546 (those don't use sudo anymore).

To post a comment you must log in.
Revision history for this message
Brian Waldon (bcwaldon) wrote :

Looks good.

review: Approve
Revision history for this message
Dan Prince (dan-prince) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.