Merge lp://qastaging/~tualatrix/ubuntuone-control-panel/fix-the-scrollbar into lp://qastaging/ubuntuone-control-panel

Proposed by Ding Zhou
Status: Rejected
Rejected by: Natalia Bidart
Proposed branch: lp://qastaging/~tualatrix/ubuntuone-control-panel/fix-the-scrollbar
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 13 lines (+1/-0)
1 file modified
data/overview.ui (+1/-0)
To merge this branch: bzr merge lp://qastaging/~tualatrix/ubuntuone-control-panel/fix-the-scrollbar
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Disapprove
dobey (community) Needs Information
Review via email: mp+53744@code.qastaging.launchpad.net

Description of the change

Fix the scrollbar problem, please see bug #736626

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

I think this is also fixed by https://code.launchpad.net/~evfool/ubuntuone-control-panel/fix729530/+merge/53329

Can you verify? It's a different change, but I think it fixes your bug.

review: Needs Information
Revision history for this message
Ding Zhou (tualatrix) wrote :

Hello, I can verify the change fix my bug. But I think my fix is better.

Because I also increase the width of the overview.png, it has a consistent UI like the original one.

You can see the difference:

Mine: http://launchpadlibrarian.net/66553056/Screenshot-Ubuntu%20One%20Control%20Panel-1.png

His: http://paste.ubuntu.org.cn/i83356

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Hi Tualatrix Chou,

First of all, thanks for your concern and interest in helping us.
Secondly, and sadly, we need to disapprove this change since we don't want to force any size for inner widgets. By inner widgets I mean those that are packed into the main control panel widget, which in turn is added into a main window. The only widget that has a size set is the main window, and the GTK engine will do all that is needed to resize the children properly.

This allows the re-use of the control panel widget into another container (other window, or a bigger app).

Anyways, thanks for contributing!
Cheers, Natalia.

review: Disapprove
Revision history for this message
dobey (dobey) wrote :

I also don't think we want to just scale the image as you did. I think keeping it centered is fine. And I think we instead need to add some padding around it. Having the logo/text in the image all the way against the edge of the window looks a bit odd.

Unmerged revisions

98. By Ding Zhou

Set the overview.png and overview.ui to 720px width, so that it will have no scrollbar by default

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: