Merge lp://qastaging/~tyhicks/snap-confine/fixes into lp://qastaging/~snappy-dev/snap-confine/trunk
Proposed by
Tyler Hicks
Status: | Merged |
---|---|
Merged at revision: | 50 |
Proposed branch: | lp://qastaging/~tyhicks/snap-confine/fixes |
Merge into: | lp://qastaging/~snappy-dev/snap-confine/trunk |
Diff against target: |
75 lines (+25/-8) 2 files modified
src/seccomp.c (+23/-8) src/utils.c (+2/-0) |
To merge this branch: | bzr merge lp://qastaging/~tyhicks/snap-confine/fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt (community) | Approve | ||
Review via email: mp+257019@code.qastaging.launchpad.net |
To post a comment you must log in.
r48 addresses the following:
* The write_string_ to_file( ) function doesn't flush the userspace buffer
before calling fclose() and the return value of fclose() is not checked.
This means that failed underlying write()s are not noticed.
r49 addresses the following:
* Lines in the seccomp filter file that exceed 80 characters are not handled load_filters( ) since it does not verify that a newline or
properly in seccomp_
EOF has been reached after each call to fgets().
r49 could probably be skipped for the release, if needed, since the seccomp filter is a whitelist and a line longer than 80 chars would just mean that any rule listed on that line would not be added to the whitelist.