Code review comment for lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/noScores

Revision history for this message
Leo Arias (elopio) wrote :

15 + def _named_temporary_file(self, dir=None, mode='w+t',

Please add a comment on this method about why we are striping the underscores. A link to the bug would be good too.

55 + desktop_file = fixture_setup._named_temporary_file(
56 + suffix='.desktop', dir=desktop_file_dir)

This won't work because it's a method in an object, not in the module. What we need to do is to refactor this test case to use the same fixture. Let me know if you want me to take over that part, using your branch as a prerequisite.

review: Approve

« Back to merge proposal