Code review comment for lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow

Revision history for this message
Loïc Molinari (loic.molinari) wrote :

Hi Christian.

I'm not going to comment on the change in itself but on the header inclusion part that I recently tried to fix and standardise. Everything is explained in the CODING file at the root of the project, it's mostly Qt rules plus a few things. I hope not to be too picky but I think we should try to respect these rules as best as possible to keep it clean and usable outside of the UITK.

I added the comments inline.

review: Needs Fixing

« Back to merge proposal