Merge lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/pilotTracing into lp://qastaging/ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Tim Peeters
Approved revision: 1307
Merged at revision: 1317
Proposed branch: lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/pilotTracing
Merge into: lp://qastaging/ubuntu-ui-toolkit/staging
Diff against target: 17 lines (+2/-0)
1 file modified
debian/control (+2/-0)
To merge this branch: bzr merge lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/pilotTracing
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Leo Arias (community) Approve
Review via email: mp+239575@code.qastaging.launchpad.net

Commit message

autopilot package needs to depend on python-autopilot-trace

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1306. By Cris Dywan

Use Python3 version of python-autopilot-trace

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1307. By Cris Dywan

Add python-autopilot-trace afterall - we support both

Revision history for this message
Leo Arias (elopio) wrote :

<elopio> kalikiana: for now, the toolkit deb is python 2 and 3.
<elopio> so
<elopio> maybe you should also add python-autopilot-trace
<kalikiana> elopio: we run it with python3
<kalikiana> afair we don't want to install everything twice
<elopio> kalikiana: yes, but there are aa couple of projects that still use py2 and it would be useful for them.
<elopio> we are about to remove the py2 everywhere
<kalikiana> hmmmm
<elopio> we are about to remove the py2 everywhere
<elopio> so I'm not sure if it might be worth it.
<zbenjamin> mhall119: pong
<kalikiana> elopio: idea, I can try the | magic
<elopio> kalikiana: not sure how that would help
<kalikiana> elopio: we do that for qt where the packages in the latest release were renamed
<kalikiana> qml-blabla
<elopio> kalikiana: but how would you tell when you need the 2 or the 3 version?
<kalikiana> so it's like qml-module-dragon | qtdeclarative-dragon-plugin
<kalikiana> hmmmm
<kalikiana> I guess it's not quite the same as you can have both py2 and 3
<kalikiana> unlike old and new qt
<elopio> kalikiana: also installing the py2 version won't hurt a lot, as we are already installing the 2 versions for a bunch of projects. But also not installing it wouldn't be bad, as the py2 projects will be updated and anyway they have always run without trace.
<elopio> kalikiana: so do whatever feels good for you. The change looks correct.
<kalikiana> elopio: I'm pushing a rev adding the py2
<kalikiana> should be there now
<elopio> kalikiana: ok.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

according to the commit message, python3-autopilot should depend on python3-autopilot-trace, not uitk depend on the -trace package.

Revision history for this message
Cris Dywan (kalikiana) wrote :

> according to the commit message, python3-autopilot should depend on python3
> -autopilot-trace, not uitk depend on the -trace package.

No. The "autopilot" package in this case is ubuntu-ui-toolkit-autopilot. And that's what the commit actually does, if you look at the change.

Revision history for this message
Tim Peeters (tpeeters) wrote :

ok.

So the python3-autopilot and python-autopilot dependencies can be removed, since the -trace packages depend on it?

Revision history for this message
Tim Peeters (tpeeters) wrote :

< kalikiana> timp: hmm. I see what you mean. not sure if that might be a bit confusing, though

right.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches