Code review comment for lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/pilotTracing

Revision history for this message
Leo Arias (elopio) wrote :

<elopio> kalikiana: for now, the toolkit deb is python 2 and 3.
<elopio> so
<elopio> maybe you should also add python-autopilot-trace
<kalikiana> elopio: we run it with python3
<kalikiana> afair we don't want to install everything twice
<elopio> kalikiana: yes, but there are aa couple of projects that still use py2 and it would be useful for them.
<elopio> we are about to remove the py2 everywhere
<kalikiana> hmmmm
<elopio> we are about to remove the py2 everywhere
<elopio> so I'm not sure if it might be worth it.
<zbenjamin> mhall119: pong
<kalikiana> elopio: idea, I can try the | magic
<elopio> kalikiana: not sure how that would help
<kalikiana> elopio: we do that for qt where the packages in the latest release were renamed
<kalikiana> qml-blabla
<elopio> kalikiana: but how would you tell when you need the 2 or the 3 version?
<kalikiana> so it's like qml-module-dragon | qtdeclarative-dragon-plugin
<kalikiana> hmmmm
<kalikiana> I guess it's not quite the same as you can have both py2 and 3
<kalikiana> unlike old and new qt
<elopio> kalikiana: also installing the py2 version won't hurt a lot, as we are already installing the 2 versions for a bunch of projects. But also not installing it wouldn't be bad, as the py2 projects will be updated and anyway they have always run without trace.
<elopio> kalikiana: so do whatever feels good for you. The change looks correct.
<kalikiana> elopio: I'm pushing a rev adding the py2
<kalikiana> should be there now
<elopio> kalikiana: ok.

review: Approve

« Back to merge proposal