lines 78, 123: Expand the comments like "Could not find AppLensButton" to ask if the relevant lens package is installed. Should help people who have removed it.
line 99:
+ verify( TIMEOUT, 'FilterCheckOption don\'t have two columns' ) {
+ loader.GridViewWithSpacing()['columns'] == '2'
+ }
Please use:
verify_equal( 2, TIMEOUT, 'FilterCheckOption don\'t have two columns' ) {
loader.GridViewWithSpacing()['columns'].to_i
}
instead, as it returns better error output if it fails.
line 123: wrong comment
And some small English suggestions:
61: Check Filter results list view having renderer as filter-checkoption is displayed with two columns
-> "Check Filter results list view rendered with filter-checkoption is displayed with two columns"
68: Check that filter-checkoption renderer is having two columns
-> "Check that the filter-checkoption renderer uses two columns"
and similar.
Comments on test script:
lines 28, 66, 111: Pet peeve: please use "lens" instead of "lense" oxforddictionar ies.com/ spellcheck/ ?region= us&q=lense
- http://
line 29: 'pwd' not needed
lines 78, 123: Expand the comments like "Could not find AppLensButton" to ask if the relevant lens package is installed. Should help people who have removed it.
lines 82+, and others move(button[ 'x_absolute' ].to_i + 1, button[ 'y_absolute' ].to_i + 1, 0, true) click(nil, nil, :left)
+ XDo::Mouse.
+ XDo::Mouse.
Use button.tap, it's easier & safer.
line 86,130: no need to reset "button"
line 99: GridViewWithSpa cing()[ 'columns' ] == '2' GridViewWithSpa cing()[ 'columns' ].to_i
+ verify( TIMEOUT, 'FilterCheckOption don\'t have two columns' ) {
+ loader.
+ }
Please use:
verify_equal( 2, TIMEOUT, 'FilterCheckOption don\'t have two columns' ) {
loader.
}
instead, as it returns better error output if it fails.
line 123: wrong comment
And some small English suggestions:
61: Check Filter results list view having renderer as filter-checkoption is displayed with two columns
-> "Check Filter results list view rendered with filter-checkoption is displayed with two columns"
68: Check that filter-checkoption renderer is having two columns
-> "Check that the filter-checkoption renderer uses two columns"
and similar.