Code review comment for lp://qastaging/~unity-2d-team/unity-2d/launcher-layout

Revision history for this message
Florian Boucault (fboucault) wrote :

=== modified file 'launcher/Launcher.qml'

@@ -44,11 +53,7 @@
                     list.visibleMenu.hide()
                 }
                 list.visibleMenu = item.menu
-
- /* The menu needs to never overlap with the MouseArea of
- item otherwise flickering happens when the mouse is on
- an overlapping pixel (hence the -4). */
- item.menu.show(width-4, y+height/2-list.contentY+panel.y)
+ item.menu.show(width, y + height / 2 - list.contentY + panel.y)

The contextual menu's vertical position is slightly off, it should be around 3 pixels below. The point of the arrow of the contextual menu should be at the same height as the point of the arrow showing that the application is focused.

review: Needs Fixing

« Back to merge proposal