Code review comment for lp://qastaging/~unity-2d-team/unity-2d/launcher-layout

Revision history for this message
Florian Boucault (fboucault) wrote :

=== modified file 'launcher/UnityApplications/launcherapplication.cpp'

@@ -394,6 +404,8 @@
     }
     if (m_has_visible_window != prev)
         emit hasVisibleWindowChanged(m_has_visible_window);
+
+ Q_EMIT windowCountChanged(windowCount());
 }

This is a hack taking advantage of the fact that LauncherApplication::updateHasVisibleWindow is called at the right time.

Instead you need to define a slot that will do Q_EMIT windowCountChanged(windowCount()); and connect it to BamfApplication::WindowAdded and BamfApplication::WindowRemoved signals.

review: Needs Fixing (code)

« Back to merge proposal