Code review comment for lp://qastaging/~unity-team/compiz/trunk.fix_757434

This case is only hit where a window is being restacked above a
fullscreen window (eg for when a window opens newly, or when a window
is activated and needs to be presented above a fullscreen window). In
this case, we should never ever stack a normal window above a panel or
dock, so we need to restack the docks appropriately (so that the docks
and launcher appear *above* the fullscreen window and the normal
window, this is in intention of the code at present).

The problem was that xwc.sibling at this point is *still* the sibling
window of the normal which is the one being restacked, which happens
to be the fullscreen window. And these dock windows are being
restacked *according* to this xwc, which means that dock windows were
going under normal windows which should never ever happen. This change
ensures that dock windows *always* stay on top of other windows.

Testcase

1) Fullscreen a window
2) Alt-tab to another winow
3) check if you can alt-drag that window what was just selected above
the dock. You shouldn't be able to
4) switch back to the fullscreen window and unfullscreen it
5) check if you can move the previously fullscreened window above the
panels and docks
6) switch back to the window activated during alt-tab and check if
this window can go above panels.

In no case should any window be allowed above the panels and docks.

On Thu, Apr 14, 2011 at 5:49 PM, David Barth <email address hidden> wrote:
> Review: Needs Information
> The code change itself looks safe. Its impact on the window stack sounds rather significant, with a potential to impact other use cases.
>
> Can you argument why the change will not impact regular windows, not introduce regressions. Alternatively, are there simple test procedures to ensure that regressions do not occur with the change?
> --
> https://code.launchpad.net/~unity-team/compiz/trunk.fix_757434/+merge/57630
> Your team Unity Team is subscribed to branch lp:~unity-team/compiz/trunk.
>

--
Sam Spilsbury