Nux

Code review comment for lp://qastaging/~unity-team/nux/nux.fix-gradual-degrade

Revision history for this message
Jason Smith (jassmith) wrote :

> Wouldn't using a std::set or std::multiset be more sensible than vector?

There are better data types to use here for sure. set or multi-set don't really fit the bill however since we are storing single values, not key-value type information. A heap or tree of some sort is probably where this should end up. On most systems the number of elements (now) will hover around 300 to 1000, so there is no huge pressure to get to log(n).

Either way, those types of changes should be evaluated for a future merge proposal. Further I think it's worth considering turning this class off entirely in release builds. It doesn't really do anything in a release build anyway.

« Back to merge proposal