Code review comment for lp://qastaging/~unity-team/qtmir/qtmir.api

Revision history for this message
Michael Terry (mterry) wrote :

Looking at the packaging...

+Package: qtmir-dev

This should probably be called libqtmirserver-dev instead.

+Replaces: qtmir-android-dev,

What's qtmir-android-dev from?

+Depends: qtmir-desktop (= ${source:Version}) | qtmir-android (= ${source:Version}),

I believe you want binary:Version here.

+Description: Developer files for the Qt platform abstraction plugin for a
+ Mir server.
+ .
+ Contains header files required for development using QtMir.

The first line of the description is special, don't break it across lines. I'd do something like:

Description: Header files for QtMir
 QtMir is a set of Qt5 components to enable one to write a Mir server with Qt.
 It contains a QPA (Qt Platform Abstraction) plugin which creates and manages
 a Mir server. It also exposes some internal Mir functionality.
 .
 This package contains the library headers for developers.

review: Needs Fixing (packaging)

« Back to merge proposal