Merge lp://qastaging/~unity-team/unity-lens-music/improved-result-quality into lp://qastaging/unity-lens-music
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michal Hruby | ||||
Approved revision: | 89 | ||||
Merged at revision: | 86 | ||||
Proposed branch: | lp://qastaging/~unity-team/unity-lens-music/improved-result-quality | ||||
Merge into: | lp://qastaging/unity-lens-music | ||||
Diff against target: |
102 lines (+50/-25) 1 file modified
src/musicstore-collection.vala (+50/-25) |
||||
To merge this branch: | bzr merge lp://qastaging/~unity-team/unity-lens-music/improved-result-quality | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Approve | ||
Review via email: mp+113716@code.qastaging.launchpad.net |
Commit message
Fix u1 search results to not seem too random. Lowers mem churn in musicstore scope quite a bit.
Description of the change
Fix u1 search results to not seem too random. Also fix potential crasher.
This was rooted in the fact that musicsearch.
In addition to using the new musicsearch API I also lowered memory churn quite considerably by removing the need to create a lot of Track/Album objects and do excessive string copying.
Nice, I find the presentation of results now more consistent with the rest of ulm - albums first, then individual tracks.
> Also fixed a bug where we'd pass possibly-null strings into a DeeModel. This could have been the root cause of bug #917974.
Actually null strings are handled fine by dee, I remember very well that the special casing for null strings to cause trouble when I was trying to optimize parts of dee, therefore the attached bug is a different issue and we can revert:
60 + model.append (uri != null ? uri : "",
61 + artwork_path != null ? artwork_path : "",
62 + PURCHASE_CATEGORY,
63 + mimetype != null ? mimetype : "",
64 + title != null ? title : "",
65 + artist != null ? artist : "",
66 + dnd_uri != null ? dnd_uri : "");