Code review comment for lp://qastaging/~unity-team/unity-lens-music/improved-result-quality

Revision history for this message
Michal Hruby (mhr3) wrote :

Nice, I find the presentation of results now more consistent with the rest of ulm - albums first, then individual tracks.

> Also fixed a bug where we'd pass possibly-null strings into a DeeModel. This could have been the root cause of bug #917974.

Actually null strings are handled fine by dee, I remember very well that the special casing for null strings to cause trouble when I was trying to optimize parts of dee, therefore the attached bug is a different issue and we can revert:

60 + model.append (uri != null ? uri : "",
61 + artwork_path != null ? artwork_path : "",
62 + PURCHASE_CATEGORY,
63 + mimetype != null ? mimetype : "",
64 + title != null ? title : "",
65 + artist != null ? artist : "",
66 + dnd_uri != null ? dnd_uri : "");

« Back to merge proposal