Code review comment for lp://qastaging/~unity-team/unity-lens-video/split-online-results

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Line 83: Add a comment describing what the "True" is there for. This will be convenient for those reading the code who are not familiar with the scope's source structure.

It is not obvious to me how the online vs. suggestion results differ and why they need to be "split." A comment above line 89 explaining the split and how it gets used would be very helpful.

Otherwise looks great, nice work.

review: Needs Fixing (code)

« Back to merge proposal