Code review comment for lp://qastaging/~unity-team/unity/lazy-places

Revision history for this message
Neil J. Patel (njpatel) wrote :

> I'm worried about turning something asynchronous that late in the cycle,
> whereas it's been running synchronously for most of it.

Indeed. A few of us are testing it since my proposal and throughout tonight to make sure it's okay.

> The severity of that is considered "meidum/low" by the release team.

Indeed, it's a big win for login speed.

> Is that code strictly equivalent to the previous mutter-based code?

Yep, the Place*Remote was already ready for Connect () I just needed to hook it up in the right parts of the code. The code that re-establishes connection to a dead daemon just came about as I was in there but is obviously a very useful thing to have.

« Back to merge proposal