Code review comment for lp://qastaging/~unity-team/unity/lazy-places
Revision history for this message
| Neil J. Patel (njpatel) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> @neil: You could maybe sprinkle some comments in there explaining why you are
> doing the lazy setup?
Yep, done. Also added some comments about why/when we're using Connect().
> So basically, if it's the case (we are not connected), the first click will
> show nothing, but the second will show the place entries section, isn't it?
> Would be nice for Oneiric to add a FIXME so that we update the Quicklist as
> soon as it's connected (more generally, we need dynamic Quicklist to be more
> "dynamic" and react when even remote application are updating an opened
> Quicklist).
Indeed, FIXME added.
> This isn't the only way to show the launcher.
> Ok, you Connect() the places in the other case by hovering (MouseEnter) the
> LauncherIcon which takes the case by revealing the launcher by pressing super
> or on edge activation.
This isn't to know when we show the launcher it's to know when the user _could_ be about to show the places (they'd need to hover->click, for instance), so we try and be clever and load the daemons while the user is still deciding what to do :)