Merge lp://qastaging/~unity-team/unity/new-dash-blending into lp://qastaging/unity

http://i.imgur.com/PvlCO.png
http://i.imgur.com/yY2yS.png

Screenshots from Cimi

On 24/02/12 12:55, Robert Carr wrote:
> http://i.imgur.com/PvlCO.png
> http://i.imgur.com/yY2yS.png
>
> Screenshots from Cimi

Is it just me, or is the only difference the background ?

I can't tell what has changed at all.

> On 24/02/12 12:55, Robert Carr wrote:
> > http://i.imgur.com/PvlCO.png
> > http://i.imgur.com/yY2yS.png
> >
> > Screenshots from Cimi
>
> Is it just me, or is the only difference the background ?
>
> I can't tell what has changed at all.

Open the dash with the current unity, the background color of the dash is different

Here is a picture with no color profile that might indicate the blending changes more clearly:
http://i.imgur.com/bxu4p.png . It's really hard to talk about changes like this with our uncalibrated screens...for example Cimis pictures dont look anything like what I see on my screen ? Part of it has to do with browsers doing their own color management :p

I would say its roughly 9000% more purple.

The main point though, is the Overlay blend is more cooperative with heavily white backgrounds, as it blends differently based on the luminosity of the colorization. Overall trying to reduce the amount of white in the background so we have less problems with text.

Try it out :) It's very very noticeable when running it.

Also I'm asleep right now.

On Fri 24 Feb 2012 14:52:17 NZDT, Robert Carr wrote:
> Review: Abstain
>
> Also I'm asleep right now.

I can tell... your are typing slowly

Nux branch is now at: https://code.launchpad.net/~unity-team/nux/texture-blend/+merge/94596

I'd like to see all arbitrary design constants extract out of the source into at least a const section in a source file, and use the named constants in the source.

I see the same paint code four times with an ifdef in it. Please abstract that into a function.

Yes sorry, waiting until the nux branch finishes (just redid the API again) to clean it all up...not really ready for review yet

> Yes sorry, waiting until the nux branch finishes (just redid the API again) to
> clean it all up...not really ready for review yet

Robert, mark the reviews "Work in progress" if they are not ready yet, you save time to reviewers (especially if they reviewed in their spare time, like Tim :-))!

This work depends on this branch:

https://code.launchpad.net/~unity-team/nux/texture-blend/+merge/94596

The nux branch as been reviewed and approved. Test this branch again before merging.

Will do monday morning ;-)

Are we sure the saturation is not a bit over the top? On top of a black terminal the dash/switcher bg is nearly black and over lighter backgrounds the color stands out so hard it looks a bit "unreal" or how to put it...

Mikkel, we are aware of the different colorization on dark bg. Probably we might want to slightly refine the saturation, but the improvement of this branch is already greately appreciated!

There are still #ifdefs here, if nux now supports the method please remove them.

Also, since the same drawing code is in a number of places, please extract into a function.

Hi Tim.

The IfDefs are intentional, and not related to Nux. The flow is so that on OpenGL ES2 when we always have GLSL we can avoid having to check at runtime if we are using the GLSL code path. The ifdefs could of course be removed, with the second case gone.

Not sure exactly how you want the drawing code extracted either. If you mean for example, lines 61-83 should be in a function because something similar is used elsewhere (247-271), I suppose that could be done. If we want to introduce three functions which are just, if (GLSL) Blend else DrawTexture using bla method, it should probably be in Nux instead. Jay?

The real problem is that the same window rendering code is replicated across various views, panel, etc...it's not purely a matter of copy paste to solve this at the moment though because of DrawContent, and some coupling with drawing and internal state (like in PanelView) so it doesn't seem like an appropriate time to try and fix that.

/me sighs.

OK... I relent.

No commit message specified.