Code review comment for lp://qastaging/~unity-team/unity/new-dash-blending

Revision history for this message
Tim Penhey (thumper) wrote :

I'd like to see all arbitrary design constants extract out of the source into at least a const section in a source file, and use the named constants in the source.

I see the same paint code four times with an ifdef in it. Please abstract that into a function.

review: Needs Fixing

« Back to merge proposal