Code review comment for lp://qastaging/~unity-team/unity/unity.composition-char

In IMTextEntry::CheckValidClientWindow() you do...

76 + if (1/*focused_*/)
77 + {
78 + gtk_im_context_focus_in(im_context_);
79 + }

... please don't. Either use a proper conditional statement that can change at runtime or just drop completely.

In IMTextEntry::TryHandleEvent() you don't initialize ev...

89 + CheckValidClientWindow(event.x11_window);
90 +
91 + GdkEventKey ev;
92 + KeyEventToGdkEventKey(event, ev);

... and that's asking for trouble. Maybe not in that particular case (about to be filled by the next call). Just bzero() it. Always be explicit!