Code review comment for lp://qastaging/~unity-team/unity/unity.dash-to-preview

Revision history for this message
Neil J. Patel (njpatel) wrote :

Hey, looks good and works well, have been using it for about a week.

Some comments:

- You've added an 'i' to the UBusMessages.h but forgot to add what it's for :)

- Please remove the commented out code:

//tick_source_.reset(new nux::NuxTimerTickSource);
//animation_controller_.reset(new na::AnimationController(*tick_source_));

// nux::GetGraphicsDisplay()->GetGraphicsEngine()->QRP_GetCopyTexture(
// src_texture->GetWidth(), src_texture->GetHeight(),
// layout_copy_, src_texture,
// texxform, nux::color::White);

//layout_->SetCopyPreviousFboTexture(false);

//(opening_row_y_ - layout_->GetY())/(float)layout_->GetHeight();

//SetCopyPreviousFboTexture(false);

//SetRedirectRenderingToTexture(true);
//SetCopyPreviousFboTexture(false);

// if (RedirectedAncestor())
// {
// // This is necessary when doing redirected rendering. Clean the area below this view.
// unsigned int current_alpha_blend;
// unsigned int current_src_blend_factor;
// unsigned int current_dest_blend_factor;
// GfxContext.GetRenderStates().GetBlend(current_alpha_blend, current_src_blend_factor, current_dest_blend_factor);

// GfxContext.GetRenderStates().SetBlend(false);
// GfxContext.QRP_Color(GetX(), GetY(), GetWidth(), GetHeight(), nux::Color(0.0f, 0.0f, 0.0f, 0.0f));

// GfxContext.GetRenderStates().SetBlend(current_alpha_blend, current_src_blend_factor, current_dest_blend_factor);
// }

// tick_source_.tick(g_get_monotonic_time());

// nux::animation::TickSource tick_source_;
// nux::animation::AnimationController animation_controller_;

review: Needs Fixing

« Back to merge proposal