Unity

Merge lp://qastaging/~unity-team/unity/unity.fix-810325-2 into lp://qastaging/unity

  1. unity.fix-810325-2
  2. Merge into trunk
Proposed by Mirco Müller
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 1912
Proposed branch: lp://qastaging/~unity-team/unity/unity.fix-810325-2
Merge into: lp://qastaging/unity
Diff against target: 48 lines (+20/-0)
2 files modified
com.canonical.Unity.gschema.xml (+5/-0)
plugins/unityshell/src/BGHash.cpp (+15/-0)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity/unity.fix-810325-2
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
Review via email: mp+91808@code.qastaging.launchpad.net

Description of the change

The updated Unity-part of fixing LP: #810325. This makes sure the average color - computed after a change of wallpaper - is exposed via Unity's GSettings schema. That in turn can get picked up by other applications... notify-osd in this case.

To post a comment you must log in.
Revision history for this message
Gord Allott (gordallott) wrote :

few things need fixing

24 + const gchar* AVG_BG_COLOR = "average-bg-color\0";
25 + const gchar* UNITY_SCHEMA = "com.canonical.Unity\0";

should use std::string not gchar*'s

35 + gchar* color_string = NULL;

should use unity::glib::String, from UnityCore/GlibWrapper.h - it will handle freeing when scope is lost for you and you can use it with methods.

41 + settings = g_settings_new (UNITY_SCHEMA);

we have a gsettings pointer in the object already, "client", should use that instead of creating another instance

review: Needs Fixing
Revision history for this message
Mirco Müller (macslow) wrote :

Fixes stated issues.

Revision history for this message
Gord Allott (gordallott) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.