Code review comment for lp://qastaging/~unity-team/unity/unity.fix-810325-2

Revision history for this message
Gord Allott (gordallott) wrote :

few things need fixing

24 + const gchar* AVG_BG_COLOR = "average-bg-color\0";
25 + const gchar* UNITY_SCHEMA = "com.canonical.Unity\0";

should use std::string not gchar*'s

35 + gchar* color_string = NULL;

should use unity::glib::String, from UnityCore/GlibWrapper.h - it will handle freeing when scope is lost for you and you can use it with methods.

41 + settings = g_settings_new (UNITY_SCHEMA);

we have a gsettings pointer in the object already, "client", should use that instead of creating another instance

review: Needs Fixing

« Back to merge proposal