Code review comment for lp://qastaging/~urbanape/desktopcouch/fix-516128

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Looks good, tests give one error, looks like a pasto in the import:

===============================================================================
[ERROR]: desktopcouch.bookmarks.tests.test_record

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/trial/runner.py", line 563, in loadPackage
    module = modinfo.load()
  File "/usr/lib/python2.6/dist-packages/twisted/python/modules.py", line 381, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.6/dist-packages/twisted/python/reflect.py", line 464, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/home/eric/canonical/desktopcouch/fix-516128/desktopcouch/bookmarks/tests/test_record.py", line 24, in <module>
    from desktopcouch.contacts.record import \
exceptions.ImportError: cannot import name Bookmark
-------------------------------------------------------------------------------

review: Needs Fixing

« Back to merge proposal