unity-2d

Merge lp://qastaging/~uriboni/unity-2d/add-fav-from-software-center into lp://qastaging/unity-2d/3.0

  1. add-fav-from-software-center
  2. Merge into natty
Proposed by Ugo Riboni
Status: Merged
Approved by: Florian Boucault
Approved revision: 460
Merged at revision: 464
Proposed branch: lp://qastaging/~uriboni/unity-2d/add-fav-from-software-center
Merge into: lp://qastaging/unity-2d/3.0
Diff against target: 245 lines (+106/-4)
8 files modified
launcher/LauncherItem.qml (+1/-1)
launcher/UnityApplications/CMakeLists.txt (+2/-0)
launcher/UnityApplications/launcherapplication.cpp (+26/-0)
launcher/UnityApplications/launcherapplication.h (+4/-0)
launcher/UnityApplications/launcherapplicationslist.cpp (+20/-3)
launcher/UnityApplications/launcherapplicationslist.h (+1/-0)
launcher/UnityApplications/launcherapplicationslistdbus.cpp (+30/-0)
launcher/UnityApplications/launcherapplicationslistdbus.h (+22/-0)
To merge this branch: bzr merge lp://qastaging/~uriboni/unity-2d/add-fav-from-software-center
Reviewer Review Type Date Requested Status
Florian Boucault (community) Needs Fixing
Review via email: mp+53630@code.qastaging.launchpad.net

Commit message

[launcher] Expose a new DBUS method that will be called by Software Center to add new favorites

Description of the change

This MR exposes an object to DBUS that exposes a method that when called causes a new favorite to be added to the Launcher.

This method is currently only called by Software Center in this branch:
lp:~gary-lasker/software-center/launcher-integration-plan-b

To run from that branch to test, you can run from the checkout directory:
PYTHONPATH=. python ./software-center

Note that this implements only a small part of the full spec, but it was agreed that's all we need for Natty with Unity and Software Center developers.

To post a comment you must log in.
Revision history for this message
Florian Boucault (fboucault) wrote :

The code is good. The current behaviour is reliable.

However there are several user experience issues:
- if the launcher is hidden, it should show when adding the favorite (the same way it shows when an application requests attention)
- the added item should wiggle (the same way it shows when an application requests attention) as to help the user figure out where the application is
- [SOFTWARE CENTER SPECIFIC] the option of adding to the launcher is not very noticeable at all
- [SOFTWARE CENTER SPECIFIC] the option of adding to the launcher disappears as soon as the installation is finished
- [SOFTWARE CENTER SPECIFIC] the option of adding to the launcher does not appear when clicking on the 'install' button from the list of applications

review: Needs Fixing
lp://qastaging/~uriboni/unity-2d/add-fav-from-software-center updated
456. By Ugo Riboni

Make sure the shake animation for urgent apps doesn't always run for the entire 30 loops

457. By Ugo Riboni

When a new favorite is added via software center make it urgent for a bit to attract attention

458. By Ugo Riboni

Initialize the m_forceUrgent variable to prevent a bug

459. By Ugo Riboni

Revert previous incorrect fix.

460. By Ugo Riboni

Make sure the launcher tiles shake only as long as they are in urgent state.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: