unity-2d

Code review comment for lp://qastaging/~uriboni/unity-2d/add-fav-from-software-center

  1. add-fav-from-software-center
  2. Merge into natty
Revision history for this message
Florian Boucault (fboucault) wrote :

The code is good. The current behaviour is reliable.

However there are several user experience issues:
- if the launcher is hidden, it should show when adding the favorite (the same way it shows when an application requests attention)
- the added item should wiggle (the same way it shows when an application requests attention) as to help the user figure out where the application is
- [SOFTWARE CENTER SPECIFIC] the option of adding to the launcher is not very noticeable at all
- [SOFTWARE CENTER SPECIFIC] the option of adding to the launcher disappears as soon as the installation is finished
- [SOFTWARE CENTER SPECIFIC] the option of adding to the launcher does not appear when clicking on the 'install' button from the list of applications

review: Needs Fixing

« Back to merge proposal