Merge lp://qastaging/~uriboni/unity-2d/launcher-overlays into lp://qastaging/unity-2d/3.0
Proposed by
Ugo Riboni
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Florian Boucault | ||||||||
Approved revision: | 402 | ||||||||
Merged at revision: | 396 | ||||||||
Proposed branch: | lp://qastaging/~uriboni/unity-2d/launcher-overlays | ||||||||
Merge into: | lp://qastaging/unity-2d/3.0 | ||||||||
Diff against target: |
387 lines (+230/-2) 6 files modified
launcher/LauncherItem.qml (+80/-0) launcher/LauncherList.qml (+7/-0) launcher/UnityApplications/launcherapplication.cpp (+76/-0) launcher/UnityApplications/launcherapplication.h (+28/-0) launcher/UnityApplications/launcherapplicationslist.cpp (+37/-2) launcher/UnityApplications/launcherapplicationslist.h (+2/-0) |
||||||||
To merge this branch: | bzr merge lp://qastaging/~uriboni/unity-2d/launcher-overlays | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Florian Boucault (community) | Approve | ||
Review via email:
|
Commit message
[launcher] Implement the following overlay features on launcher icons: counter, progress bar and emblem.
These overlays can be made visible and configured by external applications via libunity (which in turn uses the com.canonical.
Description of the change
Implement the following overlay features on launcher icons: counter, progress bar and emblem.
Will add more info on how to test in a comment.
To post a comment you must log in.
To test you need to have installed libunity-dev and valac-0.12 and then compile the vala application that you can find here: https:/ /pastebin. canonical. com/43585/ .vala
with this cmdline: valac --pkg unity launcherexample
Run it once without parameters to get some instructions, it should fairly self explanatory.
Here's also some notes on the feature: tionsList there's some DBUS code to "pretend" to be Unity. You may want to review that carefully as I'm not sure it's the right place to put it or if we have any way around doing that or if it should be done more globally somewhere else in unity-2d
- Emblem and counter are mutually exclusive, with counter taking priority. That's by design it seems, but I still need to ask Jason. We can change it later.
- In the constructor of LauncherApplica