Code review comment for lp://qastaging/~uriboni/unity-2d/launcher-overlays

Revision history for this message
Florian Boucault (fboucault) wrote :

> > Everything else looks great!
> >
> > One question:
> >
> > Does the 'entry' animation for the progress bar exist in Unity 3D?
> > In any case I don't think you need the anchor changes at all to achieve it.
> In
> > fact I think the whole state management should not be used in this case and
> > replaced with a simpler:
> >
> > width: launcherItem.progressBarVisible ? tile.width : 0
>
> Well, I did it that way since I tried to replicate the unity animation.
> Essentially in unity when the bar appears it seems to come in from the left,
> and with it disappears it seems to go away to the right.
> So if i just change the width to zero, it will go away in the direction of
> whatever side of the tile it is anchored, so AFAIK the anchor change is
> needed.

Fine.

« Back to merge proposal