Code review comment for lp://qastaging/~uriboni/webbrowser-app/find-in-page

Revision history for this message
Olivier Tilloy (osomon) wrote :

> In AddressBar.qml, can the following three new properties be marked
> readonly?
> findInPagePattern
> current
> count

searchSuggestions.active should be false when chrome.findInPageMode is true.

Is the removal of the 200 response code in HTTPRequestHandler.do_GET for "/suggest" intentional?

In test_activation(), after leaving the find in page mode, can you also check that the contents of the address bar are restored? Also I think the focus should be unset on the address bar when leaving this mode (and this should be tested too). The internal.resetFocus() function in Browser.qml probably is what you want to use.

review: Needs Fixing

« Back to merge proposal