Code review comment for lp://qastaging/~usc-isi/nova/extra_specs_sched

Revision history for this message
Lorin Hochstein (lorinh) wrote :

> > Any scheduler that respects capabilities will automatically support
> > heterogeneity. If the architecture request is conveyed through instance
> types,
> > then any scheduler using the existing InstanceTypeFilter filter will have
> > support for heterogeneity. The intent of the scheduler implementation here
> is
> > just to show an example of how the filter can be used to support the
> > heterogeneity.
> >
> > It's not obvious to me how to support this in a more generic way.
> > Alternatively, we could change the default filter in the
> zone_aware_scheduler
> > to use the InstanceTypeFilter. Clients could opt not to use it by
> subclassing
> > the filter and overriding the behavior. Would that be better?
>
> +1
>
> I like the idea of changing the default filter to use InstanceTypeFilter.

I'll go ahead and make that change.

« Back to merge proposal