Code review comment for lp://qastaging/~usc-isi/nova/extra_specs_sched

Revision history for this message
Lorin Hochstein (lorinh) wrote :

> Only thing I would change is revert
>
> 67 + filter_name = request_spec.get('filter',
> 68 +
> 'nova.scheduler.host_filter.InstanceTypeFilter')
>
> back to the old way and change the default in
>
> flags.DEFINE_string('default_host_filter',
> 'nova.scheduler.host_filter.AllHostsFilter',
> 'Which filter to use for filtering hosts.')
>
> since choose_host_filter() will use this if no HostFilter is defined.

Whoops, somehow I missed that flag definition. Code has been fixed.

« Back to merge proposal