OpenStack Compute (nova)

Code review comment for lp://qastaging/~usc-isi/nova/extra_specs_sched

  1. extra_specs_sched
  2. Merge into trunk
Revision history for this message
Brian Lamar (blamar) wrote :

Soooo sorry for my stale review here.

If HostState is a property, it should be host_state (it's like that in the Xen driver, but I've been meaning to file something for that.)

> #TODO(lorinh): Do the instance type extra specs check here

Is there a bug or blueprint for this? I don't think we have a standard, but it's nice to have documentation not in the code if someone else could implement this feature for you.

> # Copyright 2011 University of Southern California

I believe the Copyright header should be for OpenStack, LLC...it would make sense that contributed code would belong to the community.

Also, docstrings need to be a single line according to HACKING. If not a single line than a one-line summary, followed by a newline, followed by a summary, followed by a newline. Simple, right? haha

review: Needs Fixing
Reply

« Back to merge proposal