Merge lp://qastaging/~vanvugt/nux/fix-769957 into lp://qastaging/nux
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 356 | ||||
Proposed branch: | lp://qastaging/~vanvugt/nux/fix-769957 | ||||
Merge into: | lp://qastaging/nux | ||||
Diff against target: |
74 lines (+26/-2) 3 files modified
Nux/Nux.cpp (+1/-1) Nux/WindowThread.cpp (+23/-1) Nux/WindowThread.h (+2/-0) |
||||
To merge this branch: | bzr merge lp://qastaging/~vanvugt/nux/fix-769957 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jay Taoko (community) | Approve | ||
Unity Team | Pending | ||
Review via email: mp+62641@code.qastaging.launchpad.net |
Commit message
Fix an X11 Display leak, causing window leaks and graphics corruption (LP: #769957)
Description of the change
Fixed an X11 Display leak, which caused Window leaks of the XInputWindows for the Unity panel and launcher. This created graphics corruption each time the Unity plugin restarted (other plugins toggled).
Possibly also fixed other window/resource leaks in nux/unity which were side effects of the same display leak.
Technical notes:
1. The Window objects being leaked are the _window members of XInputWindow used by BaseWindow:
2. Given technical note #1, it is likely that a simpler workaround for this window leak problem would be to add an XFlush call to the end of XInputWindow:
Thank you for your patch! Before we can accept it, we require you to agree to inalogic's contributor agreement (http:// inalogic. com/license). If you accept it, send and email to <email address hidden> and state that you agree.