Unity

Merge lp://qastaging/~vanvugt/unity/fix-747682-trunk into lp://qastaging/unity

fix-747682-trunk
Merge into trunk

Proposed by Daniel van Vugt on 2011-09-19

Status:	Merged
Approved by:	Mirco Müller on 2011-09-22
Approved revision:	no longer in the source branch.
Merged at revision:	1604
Proposed branch:	lp://qastaging/~vanvugt/unity/fix-747682-trunk
Merge into:	lp://qastaging/unity
Diff against target:	19 lines (+3/-2) 1 file modified plugins/unityshell/src/unityshell.cpp (+3/-2)
To merge this branch:	bzr merge lp://qastaging/~vanvugt/unity/fix-747682-trunk
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Mirco Müller (community)		2011-09-19	Approve on 2011-09-22
Review via email: mp+76000@code.qastaging.launchpad.net

Description of the change

Panel shadow opacity should match panel opacity. (LP: #747682)

Now the opacity (hence the darkness) of the panel shadow scales according to the opacity setting of the panel itself. It looks much nicer and more realistic.

This fix was developed and tested on natty/unity-3, and hand-ported to unity-4. It should still work.

Revision history for this message

Andrea Cimitan (cimi) wrote on 2011-09-22:

I think we should cap the shadow opacity at a minimum value, otherwise it becomes pretty useless with low values. I don't know, could be 0.5 or even less... Also, the shadow is not redrawn when you change the panel opacity, but after clicking on the desktop (should be connected to the same draw signal the panel receives when the panel opacity option changes)

Revision history for this message

Mirco Müller (macslow) wrote on 2011-09-22:

Looks ok, works as planned... approved.

review: Approve

Revision history for this message

Andrea Cimitan (cimi) wrote on 2011-09-22:

Mirco, did you read my comment? :-)

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2011-09-23:

I agree about the redraw issue which I mentioned here:
https://bugs.launchpad.net/unity/+bug/747682/comments/25

However nothing has regressed. It's much better than it was. And all you need to do to see the shadow change is switch desktops. Or log in again of course. I don't expect people will change the opacity very frequently.

Leaving out the signal logic was intentional because I wanted the fix to be tiny, and couldn't see an easy way to make the shadow, which is the desktop window, redraw on demand. And couldn't spend any more time on it.

I disagree about thresholding at 0.5. It seems very arbitrary. Also, doing so would break when and if we finally switch the panel to use proper comiz shadowing:
https://bugs.launchpad.net/unity/+bug/747682/comments/21