Code review comment for lp://qastaging/~vanvugt/unity/fix-747682-trunk
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
I agree about the redraw issue which I mentioned here:
https:/
However nothing has regressed. It's much better than it was. And all you need to do to see the shadow change is switch desktops. Or log in again of course. I don't expect people will change the opacity very frequently.
Leaving out the signal logic was intentional because I wanted the fix to be tiny, and couldn't see an easy way to make the shadow, which is the desktop window, redraw on demand. And couldn't spend any more time on it.
I disagree about thresholding at 0.5. It seems very arbitrary. Also, doing so would break when and if we finally switch the panel to use proper comiz shadowing:
https:/