Code review comment for lp://qastaging/~vanvugt/unity/fix-861061-trunk

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

On Tue, 20 Dec 2011, Daniel van Vugt wrote:

> I thought it was obvious already, but your branch looks way to complicated to be considered for an SRU. I was assuming this one would be used in the SRU.

It may look noisy, but the majority of the noise comes from the fact that
I needed to rip out the fbo classes into something that could be tested
independently and that a few variable names were changed.

The actual *behavioural* change is the move from using one framebuffer
object per monitor to using one framebuffer object per screen. (eg, one
framebuffer object).

I'm confident that we can SRU it.

> --
> https://code.launchpad.net/~vanvugt/unity/fix-861061-trunk/+merge/82861
> You are requested to review the proposed merge of lp:~vanvugt/unity/fix-861061-trunk into lp:unity.
>

« Back to merge proposal