Merge lp://qastaging/~vauxoo/openerp-mexico-localization/sale_payment_method_dev_luis into lp://qastaging/openerp-mexico-localization
Proposed by
Luis Torres - http://www.vauxoo.com
Status: | Rejected |
---|---|
Rejected by: | Moisés López - http://www.vauxoo.com |
Proposed branch: | lp://qastaging/~vauxoo/openerp-mexico-localization/sale_payment_method_dev_luis |
Merge into: | lp://qastaging/openerp-mexico-localization |
Diff against target: |
221 lines (+196/-0) 5 files modified
l10n_mx_sale_payment_method/__init__.py (+27/-0) l10n_mx_sale_payment_method/__openerp__.py (+46/-0) l10n_mx_sale_payment_method/sale.py (+56/-0) l10n_mx_sale_payment_method/sale_view.xml (+17/-0) l10n_mx_sale_payment_method/stock.py (+50/-0) |
To merge this branch: | bzr merge lp://qastaging/~vauxoo/openerp-mexico-localization/sale_payment_method_dev_luis |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Moisés López - http://www.vauxoo.com | Disapprove | ||
Luis Torres - http://www.vauxoo.com (community) | Needs Resubmitting | ||
Rodolfo Lopez | Pending | ||
Isaac López Zúñiga | Pending | ||
Review via email: mp+131109@code.qastaging.launchpad.net |
Description of the change
Se agregaron los campos del número de cuenta y el metodo de pago a la sale, estos los toma de los datos del cliente
To post a comment you must log in.
Unmerged revisions
- 209. By Luis Torres - http://www.vauxoo.com
-
[IMP][l10n_
mx_sale_ payment_ method] Add a validation for False & improvement code - 208. By Luis Torres - http://www.vauxoo.com
-
[ADD][l10n_
mx_sale_ payment_ method] Add fields to acc_payment & payment_method in sale
Luis,
En esta línea va a marcar error cuando no tenga sale asociada. context) .sale_id. id
+ sale_id = self.browse(cursor, user, picking_id, context=
Cambiar por
+ sale_obj = self.browse(cursor, user, picking_id, context=context)
+ sale_id = sale_obj.sale_id and sale_obj.sale_id.id or False
Los write los puedes mandar a un solo write, solo para que quede más eficiente. obj.write( cursor, user, [invoice_id], {'acc_payment': acc_payment_id}, context=context) obj.write( cursor, user, [invoice_id], {'pay_method_id': payment_method_id}, context=context)
219 + invoice_
220 + invoice_
Cambiar a obj.write( cursor, user, [invoice_id], {'acc_payment': acc_payment_id, 'pay_method_id': payment_method_id}, context=context)
219 + invoice_