Merge lp://qastaging/~verterok/landscape-charm/support-postgresql-charm-v2-protocol into lp://qastaging/~landscape/landscape-charm/trunk

Proposed by Guillermo Gonzalez
Status: Superseded
Proposed branch: lp://qastaging/~verterok/landscape-charm/support-postgresql-charm-v2-protocol
Merge into: lp://qastaging/~landscape/landscape-charm/trunk
Diff against target: 277 lines (+66/-60)
9 files modified
lib/apt.py (+1/-1)
lib/callbacks/scripts.py (+1/-1)
lib/callbacks/tests/test_scripts.py (+11/-0)
lib/relations/postgresql.py (+30/-35)
lib/relations/tests/test_postgresql.py (+6/-16)
lib/services.py (+2/-1)
lib/tests/sample.py (+4/-3)
lib/tests/stubs.py (+1/-1)
lib/tests/test_services.py (+10/-2)
To merge this branch: bzr merge lp://qastaging/~verterok/landscape-charm/support-postgresql-charm-v2-protocol
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Needs Fixing
Landscape Pending
Review via email: mp+369964@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2019-07-15.

Commit message

use postgresql-charm v2 protocol, manually parse the dsn as the available psycopg2 (2.6.x) doesn't provide parse_dsn (added in 2.7.x)

Description of the change

use postgresql-charm v2 protocol.
As we are using system packages for python deps, manually parse the dsn as the available psycopg2 (2.6.x) doesn't provide parse_dsn (added in 2.7.x).

This change is to be able to replace postgresql unit in the juju deploy with a external-services charm which acts as a proxy to connect to metal/external deployments of postgresql.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Needs Fixing (test results)
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Oh, unittests...fancy. will fix and re-submit.

402. By Guillermo Gonzalez

add test for PostgreSQLProvider

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches