Landscape Charm

Merge lp://qastaging/~verterok/landscape-charm/support-postgresql-charm-v2-protocol into lp://qastaging/~landscape/landscape-charm/trunk

  1. support-postgresql-charm-v2-protocol
  2. Merge into trunk
Proposed by Guillermo Gonzalez
Status: Merged
Approved by: Guillermo Gonzalez
Approved revision: 402
Merged at revision: 399
Proposed branch: lp://qastaging/~verterok/landscape-charm/support-postgresql-charm-v2-protocol
Merge into: lp://qastaging/~landscape/landscape-charm/trunk
Diff against target: 296 lines (+78/-61)
9 files modified
lib/apt.py (+1/-1)
lib/callbacks/scripts.py (+1/-1)
lib/callbacks/tests/test_scripts.py (+11/-0)
lib/relations/postgresql.py (+30/-35)
lib/relations/tests/test_postgresql.py (+18/-17)
lib/services.py (+2/-1)
lib/tests/sample.py (+4/-3)
lib/tests/stubs.py (+1/-1)
lib/tests/test_services.py (+10/-2)
To merge this branch: bzr merge lp://qastaging/~verterok/landscape-charm/support-postgresql-charm-v2-protocol
Reviewer Review Type Date Requested Status
Simon Poirier (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+370150@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-07-10.

Commit message

use postgresql-charm v2 protocol, manually parse the dsn as the available psycopg2 (2.6.x) doesn't provide parse_dsn (added in 2.7.x)

Description of the change

use postgresql-charm v2 protocol.
As we are using system packages for python deps, manually parse the dsn as the available psycopg2 (2.6.x) doesn't provide parse_dsn (added in 2.7.x).

This change is to be able to replace postgresql unit in the juju deploy with a external-services charm which acts as a proxy to connect to metal/external deployments of postgresql.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) : Posted in a previous version of this proposal
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote : Posted in a previous version of this proposal

Command: make ci-test
Result: Fail
Revno: 400
Branch: lp:~verterok/landscape-charm/support-postgresql-charm-v2-protocol
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3974/

review: Needs Fixing (test results)
Revision history for this message
Guillermo Gonzalez (verterok) wrote : Posted in a previous version of this proposal

Oh, unittests...fancy. will fix and re-submit.

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 401
Branch: lp:~verterok/landscape-charm/support-postgresql-charm-v2-protocol
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3983/

review: Approve (test results)
lp://qastaging/~verterok/landscape-charm/support-postgresql-charm-v2-protocol updated
402. By Guillermo Gonzalez

add test for PostgreSQLProvider

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 402
Branch: lp:~verterok/landscape-charm/support-postgresql-charm-v2-protocol
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3984/

review: Approve (test results)
Revision history for this message
Simon Poirier (simpoir) wrote :

+1 verified with clean deployment, and attached another franken-landscape using external-services

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches